Fixed defmt on direct-boot mode #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Sep 5, 2022
| *(.uninit .uninit.*); | ||
| . = ALIGN(4); | ||
| __euninit = .; | ||
| } > REGION_BSS |
There was a problem hiding this comment.
nitpicking but maybe we should define an alias in db-esp32c3-memory.x like it's done for other regions - doesn't change anything but would look more consistent
There was a problem hiding this comment.
I merely reposted the original solution from @9names, I have no experience with linker scripts so I'm not sure how to do that 😅
Feel free to modify the PR though!
|
I'd be fine with merging this since it solves the original problem @jessebraham fine with this? |
|
No complaints from me! |
jessebraham
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #175
Ideally, I would also like to add this for the regular boot mode. I have not tested that yet.
Author is @9names, I merely submitted the PR.